[es] Remove unused indexCache #5408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5408 +/- ##
==========================================
- Coverage 95.19% 95.19% -0.01%
==========================================
Files 346 346
Lines 16908 16899 -9
==========================================
- Hits 16096 16087 -9
Misses 611 611
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pushkarm029
approved these changes
May 2, 2024
Pushkarm029
pushed a commit
to Pushkarm029/jaeger
that referenced
this pull request
May 4, 2024
## Which problem is this PR solving? - The cache was initialized with incorrect parameter, and when I looked around it wasn't even used anywhere ## Description of the changes - delete indexCache and indexCacheTTL argument ## How was this change tested? ``` $ go test ./plugin/storage/es/spanstore ok github.com/jaegertracing/jaeger/plugin/storage/es/spanstore 0.471s ``` Signed-off-by: Yuri Shkuro <github@ysh.us>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?